Add Tatu 9401 V2 #18
Merged
Add Tatu 9401 V2 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flowln
reviewed
Feb 12, 2025
In sophys-qua the definition used V1 and V2, but just deleted the pulses for V2. Since we should avoid forcing a class to implement a attribute/method that the class does not use, the solution is to have a base device with the bare minimum.
flowln
approved these changes
Feb 13, 2025
Igort4
requested review from
RafaelLyra8
and removed request for
RafaelLyra8
RafaelLyra8
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the TATU9401 V2 device, which implements a set of new PVs for output conditions. Some of the PVs are the same as the V1.