docs: PHPStan Codeigniter no type specified
#7884
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
reviewed
Sep 11, 2023
ddevsr
force-pushed
the
codeigniter-system-specified
branch
from
5508508 to
0fb7754
Compare
kenjis
reviewed
Sep 15, 2023
| 'message' => '#^Parameter \\#1 \\$node \\(PhpParser\\\\Node\\\\Stmt\\) of method Utils\\\\PHPStan\\\\CheckUseStatementsAfterLicenseRule\\:\\:processNode\\(\\) should be contravariant with parameter \\$node \\(PhpParser\\\\Node\\) of method PHPStan\\\\Rules\\\\Rule\\<PhpParser\\\\Node\\>\\:\\:processNode\\(\\)$#', | ||
| 'count' => 1, | ||
| 'path' => __DIR__ . '/utils/PHPStan/CheckUseStatementsAfterLicenseRule.php', | ||
| ]; | ||
|
|
||
| return ['parameters' => ['ignoreErrors' => $ignoreErrors]]; |
There was a problem hiding this comment.
You removed too many lines in phpstan-baseline.php.
So now there are 931 errors.
Error: [ERROR] Found 931 errors
https://github.com/codeigniter4/CodeIgniter4/actions/runs/6192815305/job/16813443982?pr=7884
There was a problem hiding this comment.
Sorry, i missed merge conflict. Soon i'll make another PR fresh
There was a problem hiding this comment.
Btw, setup job PullRequests still read
https://github.com/codeigniter4/CodeIgniter4/actions/runs/6195799415/job/16821194249?pr=7884
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #7830
Checklist: