Implement benchmarks for Flash Attention #223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammad-tanvir-1211
force-pushed
the
flash_bench
branch
from
9ba23eb to
5796bd5
Compare
muhammad-tanvir-1211
force-pushed
the
flash_bench
branch
from
20ae95f to
2dfafdf
Compare
aacostadiaz
reviewed
Feb 24, 2025
Comment on lines
31
to
34
| cutlass_benchmark_add_executable( | ||
| flash_attention_benchmark | ||
| main.cpp | ||
| ) |
There was a problem hiding this comment.
Instead of creating a new benchmark, could you integrate flash attention into the current benchmark framework alongside the existing benchmarks for GEMM and StreamK. This will allow us to add new benchmark cases without having to add each one independently in CI
There was a problem hiding this comment.
Added the Flash Attention benchmarks into the existing benchmark framework.
aacostadiaz
reviewed
Feb 24, 2025
| @@ -0,0 +1,65 @@ | |||
| # BFloat16 benchmarks | |||
There was a problem hiding this comment.
Add all these benchmark configurations into the existing input.in file so that they will all be included in the CI benchmark.
There was a problem hiding this comment.
Done.
muhammad-tanvir-1211
force-pushed
the
flash_bench
branch
from
8cbc20c to
9514513
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds benchmarks for Flash Attention v2.
Stacked changes on top of #204