-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with _3
and _2.13
dependencies
#1301
Conversation
Fansi 0.4.0 uses Scala 2.13.8 instead of 2.13.4 for Scala 2.13. This seems to have a good effect with Scala 3 compatibility, since now we can swap the artifacts and our tests are not failing anymore.
Just tested: @main def main(name: String) = {
println(s"Hello, $name!")
}
N.b. removing the |
I didn't fix the |
Oh right, sorry I didn't get that. Yes I can confirm, merging this and then a slightly modified version of #1298 gives us |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting approach. I think we can incorporate this, but I find the new use_3
object quite confusing right now. I hope I find more time later to better understand the code. Would be nice, if we could avoid the many indirections and lookups and the inner deps
method in favor of some more explicit def
s each resulting in single concrete ivy dependency.
I get the dependencies via string so it's impossible to add a dependency without also adding it to the |
@lolgab I tried hack down what I had in mind. Can you please have a look at #1302 and let me know, whether this improves readability of the dependency setup? |
Thank you @lefou. I merged your changes. As you said, few people touch this repo and we can add the dependencies manually to the list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The final goal should be still to support Scala 3 directly, but it's a nice trick to get it work now. Thank you!
mainargs 0.2.3 added support for scala3 🎉 com-lihaoyi/mainargs#18 The first attempt to upgrade and enable mainargs was com-lihaoyi#1298, but the build changes were better handled by com-lihaoyi#1301 So the only thing left is reenabling mainargs for Scala 3.
mainargs 0.2.3 added support for scala3 🎉 com-lihaoyi/mainargs#18 The first attempt to upgrade and enable mainargs was #1298, but the build changes were better handled by #1301 So the only thing left is reenabling mainargs for Scala 3.
Fixes #1241
Having a sane classpath using the Scala 2.13 compiler to compile a Scala 3 project is hard.
This uses some tricks to compile using Scala 2.13 dependencies (since we need the Scala 2.13 macros) and then change the artifacts with Scala 3 artifacts so the Ammonite runtime can compile the macros using the Scala 3 compiler.