-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Produce semanticDB for Java #2226
Comments
I already started this integration in a branch (https://github.com/com-lihaoyi/mill/compare/semantic-db-task-java, commit: b830c1d). I don't remember exactly what the issue was, but I think it was not working for Java 8 and 11. |
I think it might be the other way around. I know when I worked on |
Hmm, no. I tried to resurrect that branch and created a draft PR with an example project. |
Commented in the pr. But I hit on that as well in the past and I believe it's due to a missing flag. |
Just to tie these together. If anyone is trying this out and still getting a warning when using Metals, you'll need to make sure you're using a version of Metals that has this commit: scalameta/metals#4816. |
#1977 introduced much better support for Metals users since they will now get semanticDB support for Scala. One follow-up to that pr is that Java modules still don't produce semanticDB for Java. This means that when using Metals you will be warned upon your build import that something is not fully working with your build. When you then look at the Doctor you see:
We should be able to follow a similar way that we do for Scala, but utilizing https://github.com/sourcegraph/scip-java. I do also have an example of this working in https://github.com/ckipp01/mill-scip/blob/487f6dc806e91eb22bb625fa139a2538fb29ad97/plugin/src/io/kipp/mill/scip/Scip.scala#L144-L215.
The text was updated successfully, but these errors were encountered: