refactor: improve reporting on Semanticdb from Mill for Java Modules #4816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to the work that I've done in scalameta#4295. At that time I only applied the changes to Scala Targets since Semanticdb was only produced there when using Mill as your build server. Now that com-lihaoyi/mill#2227 is merged Java Targets and mixed targets will now also produce semanticdb. We now add the extra check for Mill and its version when we check for semanticdb java support. This will ensure that users won't get the error in the Doctor about lacking support.
ckipp01
force-pushed
the
millJavaSemanticdb
branch
from
2e5bd0a to
503279c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the work that I've done in
#4295. At that time I only
applied the changes to Scala Targets since Semanticdb was only produced
there when using Mill as your build server. Now that com-lihaoyi/mill#2227
is merged Java Targets and mixed targets will now also produce
semanticdb. We now add the extra check for Mill and its version when we
check for semanticdb java support. This will ensure that users won't get
the error in the Doctor about lacking support.
CC @lefou