Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SoftReference instead of WeakReference for caches #1966

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Use SoftReference instead of WeakReference for caches #1966

merged 1 commit into from
Jul 21, 2022

Conversation

lolgab
Copy link
Member

@lolgab lolgab commented Jul 20, 2022

SoftReferences are better suited to implement memory-sensitive caches.

Suggested in a code review in bloop: scalacenter/bloop#1761 (comment)

lefou
lefou approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lolgab lolgab marked this pull request as ready for review July 20, 2022 14:36
@lefou lefou merged commit c81ac64 into com-lihaoyi:main Jul 21, 2022
@lefou lefou added this to the after 0.10.5 milestone Jul 21, 2022
@lefou
Copy link
Member

lefou commented Jul 21, 2022

Thank you!

@lolgab lolgab deleted the soft-reference branch July 22, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.6
Development

Successfully merging this pull request may close these issues.
2 participants
@lolgab @lefou