Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filesystem-dependent sig in PathRef #1992

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Fix filesystem-dependent sig in PathRef #1992

merged 1 commit into from
Aug 15, 2022

Conversation

atty303
Copy link
Contributor

@atty303 atty303 commented Aug 15, 2022 •
edited by lefou
Loading

@lefou lefou changed the title #1808 fix filesystem-dependent sig Fix filesystem-dependent sig in PathRef Aug 15, 2022
lefou
lefou approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@lefou lefou merged commit eb76f8e into com-lihaoyi:main Aug 15, 2022
@lefou lefou added this to the 0.10.6 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.6
Development

Successfully merging this pull request may close these issues.

PathRef for directories is filesystem-dependent and not reproducible
2 participants
@atty303 @lefou