Reduce Java Heap for Mill Client #4163
Conversation
|
facepalm. Its also added to the test-runner (mill.testrunner.entrypoint.TestRunnerMain), creating out of memory exceptions. Will take a look later. |
gamlerhart
force-pushed
the
reduce-memory-size-of-client
branch
2 times, most recently
from
096c27c to
2819232
Compare
|
Question: Are some tests flacky? And if so, how can I rerun that specific test suite/github action? |
|
yes some tests are flaky. I'll give them a kick |
gamlerhart
force-pushed
the
reduce-memory-size-of-client
branch
from
2819232 to
aa24db9
Compare
gamlerhart
force-pushed
the
reduce-memory-size-of-client
branch
from
aa24db9 to
51a1198
Compare
|
@gamlerhart could you test this out with Mill's new ability to download JVMs on demand using Coursier (https://mill-build.org/mill/main-branch/cli/installation-ide.html#_customizing_mills_jvm)? I expect that will take more memory than the base Mill client, and we should adjust the number accordingly |
gamlerhart
force-pushed
the
reduce-memory-size-of-client
branch
from
51a1198 to
3dac87b
Compare
|
The Memory is enough to download a JDK. It downloaded a Zulu JDK without issues for me. However, the question is if this PR is still required. Now that we have native Graal clients, I assume most setups will use those. So, this optimization is less relevant. |
gamlerhart
force-pushed
the
reduce-memory-size-of-client
branch
from
3dac87b to
0631a67
Compare
|
I think it's still worth doing. We will need to continue support the JVM launcher anyway, either as a cross-platform launcher, or for platforms like Windows-ARM (e.g. my surface 7 laptop) that do not have Graal native image support yet |
The Mill Client only forwards requests and therefore does not need much memory. However, Java doesn't know that an allocates a large heap based on the machines memory size. Therefore, give a way lower heap limit, creating a leaner client memory wise.
gamlerhart
force-pushed
the
reduce-memory-size-of-client
branch
from
0631a67 to
35b100f
Compare
|
Thanks @gamlerhart ! |
The Mill Client only forwards requests and therefore does not need much memory. However, Java doesn't know that an allocates a large heap based on the machines memory size. Therefore, give a way lower heap limit, creating a leaner client memory wise. Example on my machine: - Before: A Mill client reserved ~500MByte - After: A Mill client reserves the specified 24Mbyte This is mostly relevant for a long running mill client (examples `--watch` clients, `-i --no-build-lock` and --bsp`). Co-authored-by: Li Haoyi <[email protected]>
The Mill Client only forwards requests and therefore does not need much memory.
However, Java doesn't know that an allocates a large heap based on the machines memory size.
Therefore, give a way lower heap limit,
creating a leaner client memory wise.
Example on my machine:
This is mostly relevant for a long running mill client (examples
--watchclients,-i --no-build-lockand --bsp`).