Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in map view fragment #1182

Merged
merged 1 commit into from
Feb 25, 2018
Merged

Conversation

maskaravivek
Copy link
Member

@maskaravivek maskaravivek commented Feb 23, 2018

Fixes crash on orientation change in the map view fragment

Fixes #1181

Updating upstream(map view SDK version) fixes this issue. Apparently they fixed this issue in this diff. mapbox/mapbox-gl-native#10589

@codecov-io
Copy link

Codecov Report

Merging #1182 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1182   +/-   ##
======================================
  Coverage    3.82%   3.82%           
======================================
  Files         125     125           
  Lines        5798    5798           
  Branches      568     568           
======================================
  Hits          222     222           
  Misses       5561    5561           
  Partials       15      15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a2b51...2979cfe. Read the comment docs.

@misaochan misaochan merged commit 2773e24 into commons-app:master Feb 25, 2018
@maskaravivek maskaravivek deleted the crashFix branch September 12, 2018 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orientation Change in NearybyActivity during Map mode crashes the app.
3 participants