Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline handling of invalid amino acids (B, J, O, U, X, Z) #31

Closed
RalfG opened this issue Feb 22, 2021 · 0 comments · Fixed by #30
Closed

Streamline handling of invalid amino acids (B, J, O, U, X, Z) #31

RalfG opened this issue Feb 22, 2021 · 0 comments · Fixed by #30
Labels
bug
Milestone
v2.0.0-beta.5

Comments

@RalfG
Copy link
Member

RalfG commented Feb 22, 2021

Non-canonical amino acids are not supported by MS²PIP (and DeepLC?), PSMs including these amino acids should be removed consequently across MS²ReScore pipelines.
@RalfG RalfG added the bug label Feb 22, 2021
@RalfG RalfG added this to the v2.0.0 milestone Feb 22, 2021
RalfG added a commit that referenced this issue Mar 2, 2021
@RalfG
Remove invalid AAs in all pipelines (fixes #31)
d740dd9
@RalfG RalfG linked a pull request Mar 2, 2021 that will close this issue
v2.0.0-beta.5 #30
Merged
@RalfG RalfG modified the milestones: v2.0.0, v2.0.0-beta.5 Mar 2, 2021
@RalfG RalfG mentioned this issue Mar 2, 2021
Merged
@RalfG RalfG closed this as completed in #30 Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.0.0-beta.5
Development

Successfully merging a pull request may close this issue.

v2.0.0-beta.5 compomics/ms2rescore
1 participant
@RalfG