-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEAKS support and various fixes/improvements #35
Merged
RalfG
merged 28 commits into
compomics:master
from
ArthurDeclercq:feature/Peaks_id_file_parser
Dec 14, 2021
Merged
PEAKS support and various fixes/improvements #35
RalfG
merged 28 commits into
compomics:master
from
ArthurDeclercq:feature/Peaks_id_file_parser
Dec 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfG
requested changes
Oct 21, 2021
ArthurDeclercq
commented
Nov 5, 2021
paretje
requested changes
Nov 8, 2021
RalfG
reviewed
Dec 10, 2021
RalfG
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
Bugfixes
0.0
(including lines ending on10.0
) were removed, instead of only 0 intensity peaks. This is now fixed.Refactoring and minor changes
R.IM[+15.99492]MAR.D
).CHARGE
in MGF file. (Identification and instrument precursor charges do not always match; identification charge should be prioritized).mgf
option frommaxquant_to_rescore
configuration.