Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEAKS support and various fixes/improvements #35

Merged
merged 28 commits into from
Dec 14, 2021
Merged

PEAKS support and various fixes/improvements #35

merged 28 commits into from
Dec 14, 2021

Conversation

ArthurDeclercq
Copy link
Collaborator

@ArthurDeclercq ArthurDeclercq commented Oct 11, 2021

Improvements

  • Added support for PEAKS mzid identification files!.
  • Retention time predictor calibrates now for each raw file independently resulting in more accurate calibrations.

Bugfixes

  • MaxQuant pipeline: Carbamidomethyl is not listed as default fixed modification anymore, as this could not be overridden. Searches without carbamidomethyl as fixed modification are now supported. However, carbamidomethyl now always needs to be specified explicitly if applicable!
  • When parsing MGF files, all lines ending on 0.0 (including lines ending on 10.0) were removed, instead of only 0 intensity peaks. This is now fixed.

Refactoring and minor changes

  • PIN pipeline: Allow mass shift modification labels with + sign (e.g. R.IM[+15.99492]MAR.D).
  • PEAKS and MaxQuant pipelines: Precursor charge from ID file now overwrites CHARGE in MGF file. (Identification and instrument precursor charges do not always match; identification charge should be prioritized).
  • Plotting module can only be run when Percolator is run as part of MS²Rescore.
  • If no decoy PSMs are present, MS²Rescore raises an error and stops.
  • Removed obsolete mgf option from maxquant_to_rescore configuration.

@ArthurDeclercq ArthurDeclercq marked this pull request as ready for review October 11, 2021 14:27
@RalfG RalfG merged commit 1a95e0c into compomics:master Dec 14, 2021
@RalfG RalfG changed the title Feature/peaks id file parser PEAKS support and various fixes/improvements Dec 14, 2021
@RalfG RalfG modified the milestones: v2.0.0, v2.1.0 Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants