Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid pandas deprecation warnings and other minor improvements #46

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Avoid pandas deprecation warnings and other minor improvements #46

merged 2 commits into from
Mar 2, 2022

Conversation

ArthurDeclercq
Copy link
Collaborator

@ArthurDeclercq ArthurDeclercq commented Mar 1, 2022 •
edited by RalfG
Loading

Fixed

  • Set default value of mgf_title_pattern to None to be compatible with PEAKS pipeline

Refactoring and minor changes

  • Replaced pandas.append with pandas.concat to remove deprecation warnings
  • Replaced empty pandas.series with dict to remove deprecation warnings
  • Removed shell=True for percolator command

@ArthurDeclercq ArthurDeclercq merged commit 51a99a0 into compomics:master Mar 2, 2022
@ArthurDeclercq ArthurDeclercq deleted the fix/deprecated_warnings_pandas branch March 2, 2022 10:51
@RalfG RalfG changed the title Fix/deprecated warnings pandas Fix pandas deprecation warnings and other fixes Mar 3, 2022
@RalfG RalfG changed the title Fix pandas deprecation warnings and other fixes Avoid pandas deprecation warnings and other minor improvements Mar 3, 2022
@RalfG RalfG added this to the v2.1.1 milestone Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug enhancement refactoring
Projects
None yet
Milestone
v2.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ArthurDeclercq @RalfG