This repository has been archived by the owner on Oct 17, 2023. It is now read-only.
add type check for map slice and mejson.M/S #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jipperinbham
force-pushed
the
314-mejson-fix
branch
from
afd3ba1 to
0f86e6c
Compare
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
==========================================
+ Coverage 82.11% 82.23% +0.11%
==========================================
Files 50 50
Lines 2645 2651 +6
==========================================
+ Hits 2172 2180 +8
Misses 332 332
+ Partials 141 139 -2
Continue to review full report at Codecov.
|
postgres adaptor tests updated with new column for complex table to test the case where field is an array of map[string]interface{}
fixes #314
jipperinbham
force-pushed
the
314-mejson-fix
branch
from
1912554 to
160c2a2
Compare
atomicules
added a commit
that referenced
this pull request
May 9, 2022
MySQL doesn't support Json arrays. Well, at least not in the same way as Postgresql. This was copied over from Postgresql (see reference below). However... realised I _do_ need to add Json support as I'd skipped it initially as was developing against 5.6 which doesn't have Json support. References: #315
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postgres adaptor tests updated with new column for complex table to test the case where field is an array of map[string]interface{}
fixes #314