MAE-823: Align with latest CiviCRM version 5.51 #867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ldForm hook. Its function is covered by core (at least in 5.42), and all it seems to do is add a duplicate of the case custom fields in the activity custom fields section of the case create form.
Remove unnecessary DisplayAllCustomGroupsInCaseForm build Form hook
PHP fatal error fixes, issue #848
olayiwola-compucorp
changed the title
olayiwola-compucorp
force-pushed
the
MAE-823-align-with-civi-5.51.3
branch
from
b54b3b5 to
c00004b
Compare
Before now CiviCRM uses the same class to handle sending of bulk emails in Contact/Activity Page and Case page, this has now been separated as seen in here civicrm/civicrm-core@dcecc49, so we now use this Forn path to send emails in CiviCase also
Before now civicrm uses the value in _toContactEmails to know which email to send email to, but it now uses the "to" html field. to restrict the contact emails that will be included in the bulk email for the current form, we update the emails in the "to" field, removing those that do not belong to the current case id.
olayiwola-compucorp
force-pushed
the
MAE-823-align-with-civi-5.51.3
branch
from
3c77915 to
f186303
Compare
MAE-823: Fix bulk mail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is in order to make the extension compatible with CiviCRM version 5.51
Some of the issues that have been identified and fixed are
Before
After
Additional Details
The CRM_Civicase_Hook_SendBulkEmailTest test case is failing because of some changes that have been made to the
EmailTrait in this PR now expects from_email_address to be available in the CiviCRM core
civicrm/civicrm-core@e2615a2