approvaltests.cpp: Make conanfile compatible with mirror urls #26687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: approvaltests.cpp
Motivation
Fixes #26683
Passing multiple URLs per file in conandata.yml results in
self.conan_data["sources"][version]["url"]being a list instead of a string.This recipe had hardcoded behavior that assumed the url would always be a string, which breaks when more urls are specified (as is the case in our downstream automation).
Details
Fix the
sourcemethod to accept either a string, list or tuple as URL. I took inspiration by the implementation ofconan.tools.files.get