Support outputs in hint_noarch_python_use_python_min, also fix if/then/else flattening for non-list clauses
#2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the outdated message in assertion for no hints in `hint_noarch_python_use_python_min` tests. The tests no longer correctly failed if the check produced hints, since the message was changed. Instead, assert on plain `python_min` substring, as that is unlikely to ever disappear.
Check all `noarch: python` outputs for missing `{{ python_min }}` usage.
Move the code for grabbing test dependencies from v0 and v1 recipes
to a common function in `conda_smithy.linter.utils`.
Fixes conda-forge#2188
Fix flattening v1 `if/then/else` blocks where the `then` or `else` clauses are immediate strings rather than sublists, e.g.: ``` - if: foo then: bar else: baz ```
beckermr
reviewed
Jan 14, 2025
beckermr
reviewed
Jan 14, 2025
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
beckermr
approved these changes
Jan 15, 2025
|
Thanks. Just wanted to say it's always a pleasure working with you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
newsentrypython conda_smithy/schema.py)Add support for checking
python_minuse in multi-output recipes (#2188). This involves some minimal refactoring to move shared code into common functions.While at it, accidentally discovered a bug that the following dependency:
would be incorrectly flattened (
barwould be iterated over as a list).