-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds symjit 1.2. #29211
Adds symjit 1.2. #29211
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/symjit/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13427782844. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
It seems to build with pip install on linux but I get an "overlinking" error:
|
Looks like mac is not support, as symjit raises a ValueError when trying to import:
|
Thanks @isuruf ! |
Nice, it now builds on Linux and Windows, with the test file passing. The software does not seem to support Mac silicon yet, so that is skipped. This is ready for review! |
url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/symjit-{{ version }}.tar.gz | ||
sha256: 8b5d497d0cad18930c37fa0610b38d211ad4be56f10b533484be7b64f6d09cef | ||
|
||
build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please take a look at the following and include the 3rd party licenses:
https://conda-forge.org/docs/maintainer/adding_pkgs/#rust
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3rd party license for what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some languages (Go, rust, etc.), the current policy is to include all dependencies and their dependencies in the package.
The underlying rust code uses a number of dependencies pulled in through cargo, so cargo-bundle-licenses
automatically pulls them together and includes them in the conda package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry. I'm not familiar with rust. I did not know it was including other software. I followed the instructions in the knowledgebase.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).