Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Reponse<Empty> in tg4_group and tg4_mixer #148

Closed
wants to merge 3 commits into from
Closed

Use Reponse<Empty> in tg4_group and tg4_mixer #148

wants to merge 3 commits into from

Conversation

ethanfrey
Copy link
Contributor

Closes my last hesitation about type explosion.

If you agree, please merge this into your PR, then merge your PR into main.

@ethanfrey ethanfrey requested a review from hashedone September 15, 2021 20:32
@ethanfrey ethanfrey mentioned this pull request Sep 16, 2021
Merged
Base automatically changed from 113-auto-return-stake to main September 16, 2021 05:30
@ethanfrey
Copy link
Contributor Author

Changed my mind.
This is not a good idea. The original changes were correct.

@ethanfrey ethanfrey closed this Sep 16, 2021
@ueco-jb ueco-jb deleted the remove-tgrade-msg-hardcode branch August 30, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashedone hashedone Awaiting requested review from hashedone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ethanfrey