-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transactional producer fixes #3971
Merged
emasab
merged 7 commits into
rel193-rc2
from
bugfix/fenced-producer-after-disconnection
Sep 20, 2022
Merged
Transactional producer fixes #3971
emasab
merged 7 commits into
rel193-rc2
from
bugfix/fenced-producer-after-disconnection
Sep 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45a6035
to
d161222
Compare
The producer was incorrectly fenced after a temporary coordinator unavailability. It was calling InitProducerId to bump the epoch before aborting the transaction, while the correct order is the other way around.
Invalid transaction state transition attempted: AbortingTransaction -> CommitNotAcked
the fatal error rd_kafka_idemp_pid_fsm: Assertion `rk->rk_eos.txn_curr_coord' failed
and outdated errors, causing Operation not valid in state AbortingTransaction or AbortedNotAcked
d161222
to
9f814a6
Compare
and TxnOffsetCommitRequest producing too much logging and network requests
9f814a6
to
1e8c576
Compare
1e8c576
to
1bd5ad6
Compare
mhowlett
reviewed
Sep 19, 2022
mhowlett
reviewed
Sep 19, 2022
mhowlett
reviewed
Sep 19, 2022
mhowlett
reviewed
Sep 19, 2022
mhowlett
reviewed
Sep 19, 2022
mhowlett
reviewed
Sep 19, 2022
mhowlett
reviewed
Sep 19, 2022
mhowlett
reviewed
Sep 19, 2022
mhowlett
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor comments.
LGTM, for an RC release, given the amount of testing you've done and earlier discussions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of fixes developed while running different long running chaos tests with single and multiple brokers and several configurations.