fix: 🐛 remove double-width characters correctly #234
Conversation
|
Thanks, this looks good. Can you add a test? |
Are there any examples for reference? |
Good question -- I guess we don't really do tests in this crate. Ignore my question! |
src/utils.rs
Outdated
| @@ -719,7 +719,7 @@ fn str_width(s: &str) -> usize { | |||
| } | |||
|
|
|||
| #[cfg(feature = "ansi-parsing")] | |||
| fn char_width(c: char) -> usize { | |||
| pub fn char_width(c: char) -> usize { | |||
There was a problem hiding this comment.
If we're going to make this pub, please fold the not(feature = "ansi-parsing") variant into this function (which I think happens implicitly anyway?) and add a docstring.
There was a problem hiding this comment.
Sorry, I didn't consider it carefully. I have now made this function pub(crate).
There was a problem hiding this comment.
So you don't need it in dialoguer anymore?
There was a problem hiding this comment.
So you don't need it in dialoguer anymore?
I can add unicode_width crate in dialoguer.
|
(If you rebase on main, CI should pass.) |
Signed-off-by: 刘洋 <[email protected]> Signed-off-by: bestgopher <[email protected]>
No description provided.