-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert the custom cobra vendor #8534
Revert the custom cobra vendor #8534
Conversation
I suggest to wait before merging. Reverting would be sad. Your work is fantastic and I am optimistic we can keep it. I dropped a comment in spf13/cobra#1258 to pull in Eric who can help us speed things up upstream. Vendoring a non-release commit is already a huge improvement over vendoring a fork. |
521453b
to
e4489ce
Compare
I like this approach. We keep the great bash completions but use the upstream cobra! LGTM |
The best thing is to keep the current scripts, they work fine with cobra v1.1.1 One problem with that is that |
Vendor in the latest cobra release v1.1.1 This will hurt the completion experience but is required for proper packaging, see: containers#8528. The best solution is to keep the current scripts since they work fine with cobra v1.1.1. Signed-off-by: Paul Holzinger <[email protected]>
e4489ce
to
3d4a0e4
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Vendor in the latest cobra release v1.1.1
This will hurt the completion experience but is required for
proper packaging, see: #8528.
The best solution is to keep the current scripts since they
work fine with cobra v1.1.1.