Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/archive.statDifferent(): fix the previous change #1968

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

nalind
Copy link
Member

@nalind nalind commented Jun 12, 2024

Make the logic match the comment for real this time: instead of comparing the datestamps a second time, check the ModeType bits. h/t to @mtrmac for spotting it at https://github.com/containers/storage/pull/1962/files#r1636517199.

Make the logic match the comment for real this time: instead of
comparing the datestamps a second time, check the ModeType bits.

Signed-off-by: Nalin Dahyabhai <[email protected]>
Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@rhatdan
Copy link
Member

rhatdan commented Jun 12, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 12, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 04fd9da into containers:main Jun 12, 2024
18 checks passed
@nalind nalind deleted the dir-timestamps-matter branch June 12, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants