chore: [] Add global prettier config, run it on commit, and prettify the codebase #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andipaetzold
changed the title
|
@Jwhiles Do you want to remove prettier dev dependencies from all apps/packages as well? |
|
@andipaetzold I knew I missed something |
|
@Jwhiles Let's make that diff bigger! |
|
Nice to see this :D we were thinking about this as well while working on #543 |
shikaan
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we had lots of prettier config files in this code base, but no enforcement that code matched the rules, and nothing to cause prettier to be run other than the whims of whoever is working on a feature.
To give us more consistent code styles, and to boost my LOC contributed stats - I've added a global prettier config, and then run prettier on the whole codebase.
Reviewers, I suggest looking through this commit by commit - as the otherwise there is a lot of noise from reformatting.
If we are happy with these changes - we should still hold off on merging this until the Gatsby changes are merged - as I don't want to cause the worst merge conflict of all time.