Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): domain check when updating domain #5036

Merged
merged 1 commit into from
Feb 3, 2025
Merged

fix(api): domain check when updating domain #5036

merged 1 commit into from
Feb 3, 2025

Conversation

sistracia
Copy link
Contributor

Changes

  • Fix condition check when updating the application's domains through API.

Because the domains field was removed in removeUnnecessaryFieldsFromRequest on the previous line, make $request->has('domains') always false.

Issues

@sistracia sistracia mentioned this pull request Feb 2, 2025
Closed
@andrasbacsai
Copy link
Member

Thank you for the PR!

@andrasbacsai andrasbacsai merged commit 035db67 into coollabsio:next Feb 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sistracia @andrasbacsai