make: install ostree-container as a multicall hardlinked binary #3293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucab
commented
Dec 21, 2021
| @@ -4,6 +4,15 @@ set -xeuo pipefail | |||
| . ${KOLA_EXT_DATA}/libtest.sh | |||
| cd $(mktemp -d) | |||
|
|
|||
| # Ensure multicall is correctly set up and working. | |||
| if ! test $(which rpm-ostree) -ef $(which ostree-container); then | |||
There was a problem hiding this comment.
This "same inode" test seems to fail on CI.
I'm unsure about why, but I think it's a side-effect of how we inject custom files into the image under test.
While slightly unfortunate, I'm going to convert this into a "same digest" check instead.
This installs the `ostree-container` multicall binary as an hardlink to the existing `rpm-ostree` one. It also adds a kola tests to make sure it is actually working at runtime.
lucab
force-pushed
the
ups/multicall-hardlink
branch
from
b819b54 to
895fd52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This installs the
ostree-containermulticall binary as anhardlink to the existing
rpm-ostreeone.It also adds a kola tests to make sure it is actually working
at runtime.
Ref: #3281