dbus/download-pkgs: remove some goto statements #3298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucab
commented
Dec 23, 2021
| static gboolean | ||
| osexperimental_handle_download_packages (RPMOSTreeOSExperimental *interface, | ||
| GDBusMethodInvocation *invocation, | ||
| GUnixFDList* _fds, |
There was a problem hiding this comment.
This argument seemed unused in the original code, but I think it's just the result of dbus funky way of handling "out" parameters.
lucab
force-pushed
the
ups/dbus-ex-remove-gotos
branch
2 times, most recently
from
14c1e13 to
e7afec3
Compare
This drops a bunch of goto codepaths from the DBus DownloadPackages handler. The same logic is now expressed with usual GError handling. It aims at making future Rust integration easier by not having to deal with non-linear execution flows.
lucab
force-pushed
the
ups/dbus-ex-remove-gotos
branch
from
e7afec3 to
757f2f0
Compare
lucab
commented
Jan 20, 2022
| glnx_throw (&local_error, "No matches for \"%s\" in repo '%s'", pkg_name, source_name); | ||
| goto out; | ||
| } | ||
| return glnx_prefix_error (error, "No matches for \"%s\" in repo '%s'", pkg_name, source_name); |
There was a problem hiding this comment.
Self note: this is wrong, should have been a glnx_throw() instead, see #3344.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops a bunch of goto codepaths from the DBus DownloadPackages
handler.
The same logic is now expressed with usual GError handling.
It aims at making future Rust integration easier by not having to deal
with non-linear execution flows.