rustix: use libc backend #3841
Merged
rustix: use libc backend #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See rationale in bytecodealliance/rustix#215 I wrote it so that we can use it here. And specifically this will fix a currently s390x-specific build failure because `rustix` only depends on the `errno` crate if it's using the libc backend, and this creates currently `s390x` specific build failures for us.
jlebon
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rationale in bytecodealliance/rustix#215
I wrote it so that we can use it here.
And specifically this will fix a currently s390x-specific build failure
because
rustixonly depends on theerrnocrate if it's using thelibc backend, and this creates currently
s390xspecific build failuresfor us.
(This overlaps with #3840 and is an alternative, complementary fix)