Ensure rect never has fractional pixel values

coreyward · Mar 11, 2023 · 3ba6284 · 3ba6284
1 parent ace7b11
commit 3ba6284
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/urlBuilder.test.ts b/src/urlBuilder.test.ts
@@ -609,6 +609,15 @@ describe("buildRect", () => {
       )
     ).toThrowError()
   })
+
+  it("rounds values", () => {
+    expect(
+      buildRect(
+        { width: 30, height: 90 },
+        { top: 0.15, left: 0.1, right: 0.25, bottom: 0.05 }
+      )
+    ).toBe("3,14,20,72")
+  })
 })
 
 describe("buildQueryString", () => {

diff --git a/src/urlBuilder.ts b/src/urlBuilder.ts
@@ -269,8 +269,8 @@ export const buildRect = (
   const { width, height } = croppedImageSize(dimensions, crop)
 
   return [
-    crop.left * dimensions.width,
-    crop.top * dimensions.height,
+    Math.round(crop.left * dimensions.width),
+    Math.round(crop.top * dimensions.height),
     width,
     height,
   ].join(",")