Add check to avoid query 5xx when closing tsdb #6616
Merged
+109
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Deluiggi <[email protected]>
danielblando
changed the title
Signed-off-by: Daniel Deluiggi <[email protected]>
yeya24
reviewed
Feb 28, 2025
|
LGTM! |
SungJin1212
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
When an idle tsdb is closing, we mark the userDB as closing (or closed) and ask to close tsdb. While the tsdb is clossing and userDb is still on the ingester list, it can happen that a query request is received by the ingester and it will fail with
To avoid this from happening, we are adding a readLock similar to the acquireAppendLock, that will make sure no query request is inflight when closing an idle tsdb and it will return a empty response if the request is received after the tsdb is already closing
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]