Truncate GetLabels and GetSeries to max query length if no time provided #6618
+105
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we truncate response if |
…ovided Signed-off-by: Ahmed Hassan <[email protected]>
afhassan
force-pushed
the
fix-get-labels-range-limit
branch
from
c05250c to
700b1c2
Compare
Signed-off-by: Ahmed Hassan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
GetSeries, GetLabels, and GetLabelNames API endpoints have optional start and end time parameters. If user does not specify a start or end time parameter, we set them to
minTimeandmaxTime.This causes these requests to get rejected due to exceeding
maxQueryLengthlimitA better approach is to truncate requests and return warning message
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]