-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix breaking Hub 3 / Gaia 2 changes #3
base: master
Are you sure you want to change the base?
Conversation
Notes to self: Publish on npm as 0.6.0 + GopherJS currently requires go 1.12, while the latest SDK requires go 1.13. This may be a non-issue as this library doesn't build against the SDK source directly, but something to be aware of. |
hey @jordansexton dont want to put on any pressure, but do you perhaps know already if this will be merged/released before the cosmoshub-3 fork? |
@hukkinj1 Unfortunately it will not completed by then (the upgrade is set to occur in December 11). It is the highest priority thing I'm working on right now though. Will this affect any production applications you are running? |
It will have an effect on a production application yes, so if you you have e.g. special tips on how to make this run prior to the merge/release, that would be much appreciated (assuming the state of the branch is e.g. such that most transactions decode already?). Otherwise no stress, we'll just have to be patient then :) |
I have pushed a new branch to https://github.com/cosmos/amino-js/tree/hub-3-gaia-2-alpha This has also been published as This release is more or less just current the It doesn't include any of the actual module changes in the current version of the SDK or gaia 2.0.3 used in the Hub 3 upgrade, and will likely be missing some of the new types, or have different structures for some of them. Therefore, it might work for what you're doing, or it might not. I do not recommend relying on this for anything in production, but if you have no alternative, it might help until there is a proper release based on code generation from the SDK. |
@jordansexton a thousand thanks, you're the best! FYI: the alpha build has successfully decoded every cosmoshub-3 transaction since around 17:30 UTC yesterday. |
Hi Jordan, |
I apologize to everyone for the delay on updates here! There's been a lot of internal discussion and progress in several draft PRs on converting the Cosmos SDK to use Protobuf3 directly and eventually remove or limit the use of Amino. This led me to slow down on development of Amino-based solutions and amino-js while I was participating in these. At the outset, I thought it might prove unnecessary to complete this if Amino is not used by the SDK. However, it looks like that work will be incremental and take time, so I've resumed work on this PR. I'll have a sense of how much work is left this week and will update accordingly. For now, the alpha build I recommended @ #3 (comment) seems functional, but I would not trust it for production use. I have reprioritized keeping this library current with the SDK and Tendermint, and will follow up soon. |
Sounds good! We will release iov-core 2.0 after that :) |
any progress :) ? @jordansexton |
@antoineherzog The work on this is incomplete, but I'm on it! It was a pretty long, tedious process the first time around. I've been attempting a new solution based on reflection over the SDK and Tendermint. I'll be sure to update here and in Telegram when I have something for you. |
Great :))) |
Do you have any new ETA Jordan on this PR? |
Let us know :) |
No description provided.