Amino JSON string escaping (v2) #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh wow. this works perfectly and the memo seems fine when I queried the tx. but I can't understand why this works and keplr fails while escape logic is same. I sent tx with &, <, > characters through keplr and the memo was escaped. https://www.mintscan.io/cosmos/txs/1858CBE6DD792D915E0CE56174323D983FC1DBD3A429B755FBCEDF74EDFA7709 |
|
Seems like Keplr does not do the escaping at the correct level
So the content of the memo is changed before the encoding starts. So one effect this could have is the memo of the sign doc is not the memo of the protobuf transaction. Anyways, I'm not familiar with the Keplr codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1367
Builds on top of #1373