Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store: app hash changes with each commit #520

Closed
ebuchman opened this issue Feb 28, 2018 · 3 comments
Closed

store: app hash changes with each commit #520

ebuchman opened this issue Feb 28, 2018 · 3 comments
Assignees
@jaekwon

Comments

@ebuchman
Copy link
Member

The AppHash is the SimpleHashFromMap of the commitInfo for each store.

The commitInfo contains the Version, which increments for each height.

Thus even with empty blocks, the SDK will change the AppHash with every commit.

Is this expected behaviour ?
@ebuchman ebuchman mentioned this issue Feb 28, 2018
Closed
@jaekwon
Copy link
Contributor

jaekwon commented Feb 28, 2018

sure, yes. any reason why this wouldn't be acceptable?

@ebuchman
Copy link
Member Author

ebuchman commented Mar 1, 2018

If we want no-empty-blocks to work for SDK apps.

Unless we change this behaviour, we will have a continual stream of empty blocks because the app hash always changes.

@cwgoes cwgoes added this to the 1.0 Code Freeze milestone Apr 27, 2018
@ebuchman ebuchman mentioned this issue Apr 27, 2018
Closed
@ethanfrey ethanfrey mentioned this issue Jun 16, 2018
Closed
@ValarDragon
Copy link
Contributor

Closing in favor of #1351

MSalopek pushed a commit to MSalopek/cosmos-sdk that referenced this issue Feb 22, 2024
@czarcas7ic
run on push (cosmos#520)
5c850e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaekwon jaekwon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jaekwon @ebuchman @ValarDragon @cwgoes