Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some typos in comments #20141

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client/keys/rename_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func Test_runRenameCmd(t *testing.T) {
cmd.SetArgs([]string{fakeKeyName1, invalidName, fmt.Sprintf("--%s=%s", flags.FlagKeyringDir, kbHome)})
require.ErrorContains(t, cmd.ExecuteContext(ctx), "the new name cannot be empty or consist solely of whitespace")

// rename a key 'blah' which doesnt exist
// rename a key 'blah' which doesn't exist
cmd.SetArgs([]string{"blah", "blaah", fmt.Sprintf("--%s=%s", flags.FlagKeyringDir, kbHome)})
err = cmd.ExecuteContext(ctx)
require.Error(t, err)
Expand Down Expand Up @@ -101,7 +101,7 @@ func Test_runRenameCmd(t *testing.T) {
require.NoError(t, err)
require.Equal(t, oldAddr, renamedAddr)

// try to rename key1 but it doesnt exist anymore so error
// try to rename key1 but it doesn't exist anymore so error
cmd.SetArgs([]string{
fakeKeyName1,
fakeKeyName2,
Expand Down
2 changes: 1 addition & 1 deletion x/auth/vesting/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,7 @@ simd tx vesting create-periodic-vesting-account cosmos1.. periods.json

#### create-vesting-account

The `create-vesting-account` command creates a new vesting account funded with an allocation of tokens. The account can either be a delayed or continuous vesting account, which is determined by the '--delayed' flag. All vesting accouts created will have their start time set by the committed block's time. The end_time must be provided as a UNIX epoch timestamp.
The `create-vesting-account` command creates a new vesting account funded with an allocation of tokens. The account can either be a delayed or continuous vesting account, which is determined by the '--delayed' flag. All vesting accounts created will have their start time set by the committed block's time. The end_time must be provided as a UNIX epoch timestamp.

```bash
simd tx vesting create-vesting-account [to_address] [amount] [end_time] [flags]
Expand Down
2 changes: 1 addition & 1 deletion x/gov/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ Since this is more of a social feature than a technical feature, we'll now get i
* What is the purpose of the chain, specifically?
* best example of this is the Cosmos hub, where different founding groups, have different interpretations of the purpose of the network.

This genesis entry, "constitution" hasn't been designed for existing chains, who should likely just ratify a constitution using their governance system. Instead, this is for new chains. It will allow for validators to have a much clearer idea of purpose and the expecations placed on them while operating their nodes. Likewise, for community members, the constitution will give them some idea of what to expect from both the "chain team" and the validators, respectively.
This genesis entry, "constitution" hasn't been designed for existing chains, who should likely just ratify a constitution using their governance system. Instead, this is for new chains. It will allow for validators to have a much clearer idea of purpose and the expectations placed on them while operating their nodes. Likewise, for community members, the constitution will give them some idea of what to expect from both the "chain team" and the validators, respectively.

This constitution is designed to be immutable, and placed only in genesis, though that could change over time by a pull request to the cosmos-sdk that allows for the constitution to be changed by governance. Communities whishing to make amendments to their original constitution should use the governance mechanism and a "signaling proposal" to do exactly that.

Expand Down
2 changes: 1 addition & 1 deletion x/tx/signing/textual/internal/cbor/cbor.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ type Array struct {
elts []Cbor
}

// NewArray reutnrs a CBOR array data item,
// NewArray returns a CBOR array data item,
// containing the specified elements.
func NewArray(elts ...Cbor) Array {
return Array{elts: elts}
Expand Down
Loading