-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Ensure Legacy Validator Delegation Invariants #2198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
…gacy-val-invariant
Thank you @rigelrozanski! Will address this today 👍 |
Codecov Report
@@ Coverage Diff @@
## develop #2198 +/- ##
===========================================
+ Coverage 63.51% 63.55% +0.04%
===========================================
Files 136 136
Lines 8370 8380 +10
===========================================
+ Hits 5316 5326 +10
Misses 2692 2692
Partials 362 362 |
@rigelrozanski updated + fixed! Thanks again. |
Oh dope! - if you want to approve this PR I'll merge in |
alexanderbez
approved these changes
Aug 31, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreation of PR #2176 After Reverted Merge
Need to merge in develop and fix errors
Delegation
toValidatorSet
type. The motivation was to be able to determineif a validator has a self-delegation in the unjail message handler.
ValidatorSet
interface already hasDelegation
defined.handleMsgUnjail
to not allow a validator to unjail itself if it has noself-bonded delegation (it may have other delegated power).
handleMsgDelegate
to allow a validator to self-bond when jailed.When a validator removes it's final self-bonded share:
closes: #1883
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added entries in
PENDING.md
with issue #rereviewed
Files changed
in the github PR explorerFor Admin Use: