WIP: Fix keybase lock issues #2655

alessio · 2018-11-01T11:08:24Z

Closes: #2649

Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (docs/)
Added entries in PENDING.md with issue #
rereviewed Files changed in the github PR explorer

For Admin Use:

Added appropriate labels to PR (ex. wip, ready-for-review, docs)
Reviewers Assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Closes: #2649

codecov · 2018-11-01T11:16:43Z

Codecov Report

Merging #2655 into develop will decrease coverage by <.01%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           develop    #2655      +/-   ##
===========================================
- Coverage    58.82%   58.81%   -0.01%     
===========================================
  Files          152      152              
  Lines         9425     9422       -3     
===========================================
- Hits          5544     5542       -2     
+ Misses        3511     3510       -1     
  Partials       370      370

cwgoes

Thanks; see comments.

x/bank/client/rest/sendtx.go

client/lcd/root.go

x/slashing/client/rest/tx.go

x/stake/client/rest/tx.go

cwgoes · 2018-11-01T13:00:06Z

Fails test_cover now - and are you sure you added the CloseDB() calls after the new handlers?

faboweb · 2018-11-01T13:40:23Z

Error on latest:

electron  gaiacli: E[11-01|14:41:19.856] Panic in RPC HTTP handler                   module=rest-server err="leveldb: closed" stack="goroutine 47 [running]:\nruntime/debug.Stack(0xc00086b7c8, 0x1944400, 0xc0001b0130)\n\t/usr/local/go/src/runtime/debug/stack.go:24 +0xa7\ngithub.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/rpc/lib/server.RecoverAndLogHandler.func1.1(0xc000b72920, 0x1ef0660, 0xc0001c22e0, 0xbeeede7ff30d4e30, 0x8f7fef38, 0x262c000, 0xc000be4a00)\n\t/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/rpc/lib/server/http_server.go:174 +0x50c\npanic(0x1944400, 0xc0001b0130)\n\t/usr/local/go/src/runtime/panic.go:513 +0x1b9\ngithub.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/libs/db.(*goLevelDBIterator).assertNoError(0xc000226690)\n\t/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/libs/db/go_level_db.go:323 +0x60\ngithub.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/libs/db.(*goLevelDBIterator).Valid(0xc000226690, 0x1ef39f8)\n\t/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/libs/db/go_level_db.go:259 +0x3e\ngithub.com/cosmos/cosmos-sdk/crypto/keys.dbKeybase.List(0x1ef7aa0, 0xc0000c4088, 0x0, 0x0, 0x0, 0x0, 0x0)\n\t/go/src/github.com/cosmos/cosmos-sdk/crypto/keys/keybase.go:202+0x12b\ngithub.com/cosmos/cosmos-sdk/client/keys.QueryKeysRequestHandler.func1(0x1eee820, 0xc000b72920, 0xc000be4c00)\n\t/go/src/github.com/cosmos/cosmos-sdk/client/keys/list.go:48 +0x9d\nnet/http.HandlerFunc.ServeHTTP(0xc000bf02d0, 0x1eee820, 0xc000b72920, 0xc000be4c00)\n\t/usr/local/go/src/net/http/server.go:1964 +0x44\ngithub.com/cosmos/cosmos-sdk/vendor/github.com/gorilla/mux.(*Router).ServeHTTP(0xc000b9c700, 0x1eee820, 0xc000b72920, 0xc000be4c00)\n\t/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/gorilla/mux/mux.go:162 +0xf1\ngithub.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/rpc/lib/server.maxBytesHandler.ServeHTTP(0x1ee4f60, 0xc000b9c700, 0xf4240, 0x1eee820, 0xc000b72920, 0xc000be4a00)\n\t/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/rpc/lib/server/http_server.go:220 +0xcf\ngithub.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/rpc/lib/server.RecoverAndLogHandler.func1(0x1eeed20, 0xc000902380, 0xc000be4a00)\n\t/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/rpc/lib/server/http_server.go:193 +0x394\nnet/http.HandlerFunc.ServeHTTP(0xc000c50030, 0x1eeed20, 0xc000902380, 0xc000be4a00)\n\t/usr/local/go/src/net/http/server.go:1964 +0x44\nnet/http.serverHandler.ServeHTTP(0xc0000a4a90, 0x1eeed20, 0xc000902380, 0xc000be4a00)\n\t/usr/local/go/src/net/http/server.go:2741 +0xab\nnet/http.(*conn).serve(0xc000ba2aa0, 0x1eef860, 0xc0000abfc0)\n\t/usr/local/go/src/net/http/server.go:1847 +0x646\ncreated by net/http.(*Server).Serve\n\t/usr/local/go/src/net/http/server.go:2851 +0x2f5\n"

electron  gaiacli: I[11-01|14:41:19.856] Served RPC HTTP response                   module=rest-server method=GET url=/keys status=200 duration=0 remoteAddr=127.0.0.1:60298
          E[11-01|14:41:19.859] Panic in RPC HTTP handler          module=rest-server err="leveldb: closed" stack="goroutine 47 [running]:\nruntime/debug.Stack(0xc000a597c8, 0x1944400, 0xc0001b0130)\n\t/usr/local/go/src/runtime/debug/stack.go:24 +0xa7\ngithub.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/rpc/lib/server.RecoverAndLogHandler.func1.1(0xc000b72c80, 0x1ef0660, 0xc0001c22e0, 0xbeeede7ff3359e80, 0x8fa83e8c, 0x262c000, 0xc000be4e00)\n\t/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/rpc/lib/server/http_server.go:174 +0x50c\npanic(0x1944400, 0xc0001b0130)\n\t/usr/local/go/src/runtime/panic.go:513 +0x1b9\ngithub.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/libs/db.(*goLevelDBIterator).assertNoError(0xc000226780)\n\t/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/libs/db/go_level_db.go:323 +0x60\ngithub.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/libs/db.(*goLevelDBIterator).Valid(0xc000226780, 0x1ef39f8)\n\t/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/libs/db/go_level_db.go:259 +0x3e\ngithub.com/cosmos/cosmos-sdk/crypto/keys.dbKeybase.List(0x1ef7aa0, 0xc0000c4088, 0x0, 0x0, 0x0, 0x0, 0x0)\n\t/go/src/github.com/cosmos/cosmos-sdk/crypto/keys/keybase.go:202 +0x12b\ngithub.com/cosmos/cosmos-sdk/client/keys.QueryKeysRequestHandler.func1(0x1eee820, 0xc000b72c80, 0xc000be5000)\n\t/go/src/github.com/cosmos/cosmos-sdk/client/keys/list.go:48 +0x9d\nnet/http.HandlerFunc.ServeHTTP(0xc000bf02d0, 0x1eee820, 0xc000b72c80, 0xc000be5000)\n\t/usr/local/go/src/net/http/server.go:1964 +0x44\ngithub.com/cosmos/cosmos-sdk/vendor/github.com/gorilla/mux.(*Router).ServeHTTP(0xc000b9c700, 0x1eee820, 0xc000b72c80, 0xc000be5000)\n\t/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/gorilla/mux/mux.go:162 +0xf1\ngithub.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/rpc/lib/server.maxBytesHandler.ServeHTTP(0x1ee4f60, 0xc000b9c700,0xf4240, 0x1eee820, 0xc000b72c80, 0xc000be4e00)\n\t/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/rpc/lib/server/http_server.go:220 +0xcf\ngithub.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/rpc/lib/server.RecoverAndLogHandler.func1(0x1eeed20, 0xc000902460, 0xc000be4e00)\n\t/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/rpc/lib/server/http_server.go:193 +0x394\nnet/http.HandlerFunc.ServeHTTP(0xc000c50030, 0x1eeed20, 0xc000902460, 0xc000be4e00)\n\t/usr/local/go/src/net/http/server.go:1964 +0x44\nnet/http.serverHandler.ServeHTTP(0xc0000a4a90, 0x1eeed20, 0xc000902460, 0xc000be4e00)\n\t/usr/local/go/src/net/http/server.go:2741 +0xab\nnet/http.(*conn).serve(0xc000ba2aa0, 0x1eef860, 0xc0000abfc0)\n\t/usr/local/go/src/net/http/server.go:1847 +0x646\ncreated by net/http.(*Server).Serve\n\t/usr/local/go/src/net/http/server.go:2851 +0x2f5\n"
          I[11-01|14:41:19.859] Served RPC HTTP response          module=rest-server method=GET url=/keys status=200 duration=0 remoteAddr=127.0.0.1:60298

electron  gaiacli: 2018/11/01 14:41:19 http: multiple response.WriteHeader calls
          2018/11/01 14:41:19 http: multiple response.WriteHeader calls

alexanderbez

Seconding what @cwgoes stated

alexanderbez · 2018-11-02T09:14:30Z

@alessio added the WIP. Let us know when this is R4R again 👍

cwgoes · 2018-11-26T11:52:39Z

Bump @alessio - still relevant I think?

alessio · 2018-11-26T14:25:54Z

upstream didn't fix the issue for us, still investigating

jackzampolin · 2018-11-26T20:12:24Z

client/keys/utils.go

@@ -188,6 +188,11 @@ func Bech32ValKeyOutput(keyInfo keys.Info) (KeyOutput, error) {
 	}, nil
 }

+func CloseKeybase() {
+	keybase.CloseDB()


so is the keybase held in a global variable in this package?

cwgoes · 2019-01-17T15:27:28Z

Bump @alessio - still blocked on upstream? Maybe we should give up on this if so.

alessio · 2019-01-19T00:41:26Z

Let's leave this open. I need time to look further into upstream code

…

On Thu, 17 Jan 2019, 16:27 Christopher Goes ***@***.*** wrote: Bump @alessio <https://github.com/alessio> - still blocked on upstream? Maybe we should give up on this if so. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2655 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAN_7NTn80bUNNzP-7ledN2q5BepCVDnks5vEJZhgaJpZM4YGNAx> .

alessio · 2019-02-06T22:04:08Z

Same issue was successfully addressed by #3514. Hence closing.

Fix keybase lock issues

121d656

Closes: #2649

alessio requested review from cwgoes, ebuchman and rigelrozanski as code owners November 1, 2018 11:08

Update PENDING.md

5f9629b

alessio changed the title ~~Fix keybase lock issues~~ R4R: Fix keybase lock issues Nov 1, 2018

alessio added T:Bug ready-for-review labels Nov 1, 2018

alessio requested review from alexanderbez, jackzampolin and jaekwon November 1, 2018 11:20

Opts apparently cannot be nil

eebfcb3

cwgoes suggested changes Nov 1, 2018

View reviewed changes

x/bank/client/rest/sendtx.go Show resolved Hide resolved

client/lcd/root.go Outdated Show resolved Hide resolved

x/slashing/client/rest/tx.go Show resolved Hide resolved

x/stake/client/rest/tx.go Show resolved Hide resolved

defer keybase.Close()

3f78aa3

alexanderbez suggested changes Nov 1, 2018

View reviewed changes

Alessio Treglia added 2 commits November 1, 2018 18:08

Try to solve the locking issue with the singleton

0f23a1e

CloseKeybase after acquiring the lock

c0a7bdc

alexanderbez changed the title ~~R4R: Fix keybase lock issues~~ WIP: Fix keybase lock issues Nov 2, 2018

alexanderbez added wip and removed ready-for-review labels Nov 2, 2018

jackzampolin reviewed Nov 26, 2018

View reviewed changes

jackzampolin added the S:blocked Status: Blocked label Dec 4, 2018

alessio closed this Feb 6, 2019

alessio deleted the alessio/2649-dont-initialise-kb-on-rest-startup branch February 6, 2019 22:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Fix keybase lock issues #2655

WIP: Fix keybase lock issues #2655

alessio commented Nov 1, 2018 •

edited

Loading

codecov bot commented Nov 1, 2018 •

edited

Loading

cwgoes left a comment

cwgoes commented Nov 1, 2018

faboweb commented Nov 1, 2018

alexanderbez left a comment

alexanderbez commented Nov 2, 2018

cwgoes commented Nov 26, 2018

alessio commented Nov 26, 2018

jackzampolin Nov 26, 2018

cwgoes commented Jan 17, 2019

alessio commented Jan 19, 2019 via email

alessio commented Feb 6, 2019

WIP: Fix keybase lock issues #2655

WIP: Fix keybase lock issues #2655

Conversation

alessio commented Nov 1, 2018 • edited Loading

codecov bot commented Nov 1, 2018 • edited Loading

Codecov Report

cwgoes left a comment

Choose a reason for hiding this comment

cwgoes commented Nov 1, 2018

faboweb commented Nov 1, 2018

alexanderbez left a comment

Choose a reason for hiding this comment

alexanderbez commented Nov 2, 2018

cwgoes commented Nov 26, 2018

alessio commented Nov 26, 2018

jackzampolin Nov 26, 2018

Choose a reason for hiding this comment

cwgoes commented Jan 17, 2019

alessio commented Jan 19, 2019 via email

alessio commented Feb 6, 2019

alessio commented Nov 1, 2018 •

edited

Loading

codecov bot commented Nov 1, 2018 •

edited

Loading