Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update config.js & Makefile #2738

Merged
merged 3 commits into from
Nov 9, 2018
Merged

docs: update config.js & Makefile #2738

merged 3 commits into from
Nov 9, 2018

Conversation

zramsay
Copy link
Contributor

@zramsay zramsay commented Nov 8, 2018

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@zramsay zramsay requested a review from gamarin2 November 8, 2018 22:41
gamarin2
gamarin2 suggested changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@gamarin2 gamarin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add back "Introduction" and "Resources" (whitepapers + delegator-faq) in this PR since they have not been integrated in website yet

@zramsay zramsay merged commit 59651c9 into docs-overhaul Nov 9, 2018
@zramsay zramsay deleted the zach/examples branch November 9, 2018 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gamarin2 gamarin2 gamarin2 approved these changes

@cwgoes cwgoes Awaiting requested review from cwgoes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zramsay @gamarin2