Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Fix the bug in GetAccount when len(res) == 0 and err == nil #3141

Merged
merged 3 commits into from
Dec 21, 2018
Merged

R4R: Fix the bug in GetAccount when len(res) == 0 and err == nil #3141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29fdde2
Fix the bug in GetAccount when len(res) == 0 and err == nil
MrXJC Dec 18, 2018
8d1e160
Merge branch 'develop' of https://github.com/cosmos/cosmos-sdk into b…
MrXJC Dec 21, 2018
786a803
Add the pending log
MrXJC Dec 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion PENDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ BUG FIXES
* Gaia REST API (`gaiacli advanced rest-server`)

* Gaia CLI (`gaiacli`)

* \#3141 Fix the bug in GetAccount when `len(res) == 0` and `err == nil`

* Gaia
* \#3148 Fix `gaiad export` by adding a boolean to `NewGaiaApp` determining whether or not to load the latest version
* \#3181 Correctly reset total accum update height and jailed-validator bond height / unbonding height on export-for-zero-height
Expand Down
2 changes: 1 addition & 1 deletion client/context/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func (ctx CLIContext) GetAccount(address []byte) (auth.Account, error) {
if err != nil {
return nil, err
} else if len(res) == 0 {
return nil, err
return nil, ErrInvalidAccount(address)
}

account, err := ctx.AccDecoder(res)
Expand Down