Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge #3674 into v0.32.1 #3686

Merged
merged 18 commits into from
Feb 19, 2019
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Feb 19, 2019

PR #3674 into release v0.32.1.


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez marked this pull request as ready for review February 19, 2019 19:10
@alexanderbez alexanderbez changed the title Cherry-pick #3674 into v0.32.1 Merge #3674 into v0.32.1 Feb 19, 2019
@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #3686 into release/v0.32.1 will increase coverage by 0.57%.
The diff coverage is 89.18%.

@@                 Coverage Diff                 @@
##           release/v0.32.1    #3686      +/-   ##
===================================================
+ Coverage            60.62%   61.19%   +0.57%     
===================================================
  Files                  189      189              
  Lines                14236    14039     -197     
===================================================
- Hits                  8630     8591      -39     
+ Misses                5061     4906     -155     
+ Partials               545      542       -3

@jackzampolin jackzampolin merged commit 2b0ae5a into release/v0.32.1 Feb 19, 2019
@alexanderbez alexanderbez deleted the bez/3641-remove-pwd-rest-client branch February 19, 2019 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants