Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Hacky multisend pre transfers #3786

Closed
wants to merge 2 commits into from

Conversation

sunnya97
Copy link
Member

@sunnya97 sunnya97 commented Mar 2, 2019

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@jaekwon
Copy link
Contributor

jaekwon commented Mar 2, 2019

This is better but we're still not doing this because it would make the SDK unusable for other use-cases. instead see #3787

@jaekwon jaekwon closed this Mar 2, 2019
@cwgoes cwgoes deleted the sunny/hacky-multisend-create-account branch March 4, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants