Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port IsAllGT from safe-coins PR #3826

Merged
merged 2 commits into from
Mar 8, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 8, 2019

See #3678

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a bug fix pending log entry, but otherwise LGTM. Also a note on the function name :)

@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (sunny/coins-AllGT-test@714168f). Click here to learn what that means.
The diff coverage is 100%.

@@                    Coverage Diff                    @@
##             sunny/coins-AllGT-test    #3826   +/-   ##
=========================================================
  Coverage                          ?   60.99%           
=========================================================
  Files                             ?      192           
  Lines                             ?    14321           
  Branches                          ?        0           
=========================================================
  Hits                              ?     8735           
  Misses                            ?     5019           
  Partials                          ?      567

@alessio
Copy link
Contributor Author

alessio commented Mar 8, 2019

@alexanderbez

Missing a bug fix pending log entry

This PR goes into Sunny's branch, PENDING.md will be amended there.

@jackzampolin jackzampolin merged commit f37ab4a into sunny/coins-AllGT-test Mar 8, 2019
@jackzampolin jackzampolin deleted the alessio/coins-AllGT-test branch March 8, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants