Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set New EventManager in Context#CacheContext #4873

Merged
merged 2 commits into from
Aug 8, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Aug 8, 2019

closes: #4868


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez merged commit 0bcc7c9 into master Aug 8, 2019
@alexanderbez alexanderbez deleted the bez/4868-fix-cache-context branch August 8, 2019 16:32
@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #4873 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4873      +/-   ##
==========================================
+ Coverage   54.29%   54.31%   +0.01%     
==========================================
  Files         271      271              
  Lines       17346    17346              
==========================================
+ Hits         9418     9421       +3     
+ Misses       7230     7227       -3     
  Partials      698      698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events emitted by CanWithdrawInvariant will be saved by tendermint
2 participants