Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Slashing Spec #4892

Merged
merged 3 commits into from
Aug 12, 2019
Merged

Update Slashing Spec #4892

merged 3 commits into from
Aug 12, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Aug 12, 2019

This PR is not a complete refactor and cleanup of the existing slashing specs, but rather focuses on:

  • Cleaning up and fixing markdown
  • Usage of correct parameter names
  • Helping clarifying certain concepts focusing on liveness

ref: #4628


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #4892 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4892   +/-   ##
=======================================
  Coverage   54.04%   54.04%           
=======================================
  Files         269      269           
  Lines       17130    17130           
=======================================
  Hits         9258     9258           
  Misses       7184     7184           
  Partials      688      688

@alexanderbez alexanderbez added R4R and removed WIP labels Aug 12, 2019
@alexanderbez alexanderbez marked this pull request as ready for review August 12, 2019 15:31
@alexanderbez alexanderbez merged commit 436f440 into master Aug 12, 2019
@alexanderbez alexanderbez deleted the bez/slashing-spec-cleanup branch August 12, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants