Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IBC from the SDK #8735

Merged
merged 12 commits into from
Mar 4, 2021
Merged

Remove IBC from the SDK #8735

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
baa4c66
remove IBC
colin-axner Feb 22, 2021
2daec73
remove ibc from simapp
colin-axner Feb 22, 2021
54d72bf
merge master
colin-axner Mar 1, 2021
e7691c4
update README's
colin-axner Mar 1, 2021
d08d452
update docs README
colin-axner Mar 1, 2021
62999f8
merge master
colin-axner Mar 1, 2021
37a13ce
remove auth test and run make proto-all
colin-axner Mar 1, 2021
05ce789
remove capability ibc test
colin-axner Mar 1, 2021
1be3e7f
fix docs README for ibc
colin-axner Mar 2, 2021
2b7f74a
merge master
colin-axner Mar 4, 2021
dda7b01
fix hardcoded test
colin-axner Mar 4, 2021
ab27bc3
Merge branch 'master' into colin/remove-ibc
colin-axner Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion x/auth/ante/ante_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,8 @@ func (suite *AnteTestSuite) TestAnteHandlerFees() {
{
"signer as enough funds, should pass",
func() {
accNums = []uint64{7}
accNums = []uint64{acc1.GetAccountNumber()}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think when I removed IBC registration from simapp, one less account was being created causing the account number to become 6 and not 7. I used the account associated with addr0 since that is the account being funded in this test


modAcc := suite.app.AccountKeeper.GetModuleAccount(suite.ctx, types.FeeCollectorName)

suite.Require().True(suite.app.BankKeeper.GetAllBalances(suite.ctx, modAcc.GetAddress()).Empty())
Expand Down Expand Up @@ -511,6 +512,7 @@ func (suite *AnteTestSuite) TestAnteHandlerFees() {

for _, tc := range testCases {
suite.Run(fmt.Sprintf("Case %s", tc.desc), func() {

suite.txBuilder = suite.clientCtx.TxConfig.NewTxBuilder()
tc.malleate()

Expand Down