Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simulation tests #215

Merged
merged 6 commits into from
Dec 19, 2019
Merged

Update simulation tests #215

merged 6 commits into from
Dec 19, 2019

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Dec 9, 2019

Ref: cosmos/cosmos-sdk#5378

Description

TODO:

  • Remove dup code with SDK's SimApp
  • Use SDK's master as target branch

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze added the WIP label Dec 9, 2019
@fedekunze fedekunze changed the title update sim tests Update simulation tests Dec 19, 2019
@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #215 into master will increase coverage by 2.58%.
The diff coverage is 92.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage    66.4%   68.99%   +2.58%     
==========================================
  Files           5        4       -1     
  Lines         509      516       +7     
==========================================
+ Hits          338      356      +18     
+ Misses        140      129      -11     
  Partials       31       31
Impacted Files Coverage Δ
app/app.go 89.61% <92.5%> (+0.72%) ⬆️

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit ebfbd95 into master Dec 19, 2019
@alexanderbez alexanderbez deleted the fedekunze/sim-tests branch December 19, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants