Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): automatically merge PRs to interchaintest if they're approved #3549

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fastfadingviolets
Copy link
Contributor

Description

This will automatically merge PRs that:

  • Touch files in tests/interchain/** but no other files
  • Are made from cosmos/gaia (i.e. not from forks)
  • Are labeled as automerge
  • Have received one approval
  • Are mergeable based on branch-protection rules (i.e. status checks and CODEOWNER approvals must pass)

This should make it easier for the Hypha team to iterate over test changes in cosmos/gaia without having to always be pinging the development team.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@fastfadingviolets fastfadingviolets requested a review from a team as a code owner February 24, 2025 17:54
This will automatically merge PRs that:
* Touch files in `tests/interchain/**` but no other files
* Are made from `cosmos/gaia` (i.e. not from forks)
* Are labeled as `automerge`
* Have received one approval
* Are mergeable based on branch-protection rules (i.e. status checks and
  CODEOWNER approvals must pass)

This should make it easier for the Hypha team to iterate over test
changes in cosmos/gaia without having to always be pinging the
development team.
@fastfadingviolets fastfadingviolets force-pushed the feat-ci/automerge-interchain branch from 1135303 to 887f9b3 Compare February 24, 2025 17:59
Copy link
Contributor

@Eric-Warehime Eric-Warehime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you remove the pr targets if you agree that they're unccessary?

Comment on lines +4 to +12
types:
- labeled
- unlabeled
- synchronize
- opened
- edited
- ready_for_review
- reopened
- unlocked
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need all of these? Why isn't the PR review and checks completion sufficient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants