Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc/proto changes for GetByIndex #355

Merged
merged 9 commits into from
Feb 3, 2021
Merged

grpc/proto changes for GetByIndex #355

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ea5e147
grpc/proto changes for GetByIndex
UnitylChaos Jan 4, 2021
a6f2d0f
comment consistency
UnitylChaos Jan 4, 2021
26c4225
Missing field in Get response, basic tests, small fixes
UnitylChaos Jan 8, 2021
97f8984
Comment consistency again
UnitylChaos Jan 8, 2021
febb070
changelog
UnitylChaos Jan 18, 2021
856cbb4
Rename Missing to NotFound, collapse value=nil check in handler
UnitylChaos Feb 1, 2021
e7f8b3a
Merge branch 'master' into grpc-getbyindex
jlandrews Feb 1, 2021
6436687
Value typo
UnitylChaos Feb 1, 2021
3e5f26e
Merge branch 'grpc-getbyindex' of github.com:jlandrews/iavl into grpc…
UnitylChaos Feb 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion proto/iavl/iavl_api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,23 @@ service IAVLService {
};
}

// Get returns a result containing the IAVL tree version and value for a given
// Get returns a result containing the index and value for a given
// key based on the current state (version) of the tree.
// If the key does not exist, Get returns the index of the next value.
rpc Get(GetRequest) returns (GetResponse) {
option (google.api.http) = {
get: "/v1/get"
};
}

// GetByIndex returns a result containing the key and value for a given
// index based on the current state (version) of the tree.
rpc GetByIndex(GetByIndexRequest) returns (GetByIndexResponse) {
option (google.api.http) = {
get: "/v1/getbyindex"
};
}

// GetWithProof returns a result containing the IAVL tree version and value for
// a given key based on the current state (version) of the tree including a
// verifiable Merkle proof.
Expand Down Expand Up @@ -217,6 +226,10 @@ message GetRequest {
bytes key = 1;
}

message GetByIndexRequest {
int64 index = 1;
}

message GetVersionedRequest {
int64 version = 1;
bytes key = 2;
Expand Down Expand Up @@ -283,6 +296,12 @@ message HasResponse {
message GetResponse {
int64 index = 1;
bytes value = 2;
bool missing = 3;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about changing to more standard not_found (like in HTTP) or exists (like in SQL)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, not_found sounds good. I think it makes sense for the zero value to default to the typical case where the key exists.

}

message GetByIndexResponse {
bytes key = 1;
bytes value = 2;
}

message SetResponse {
Expand Down
Loading