Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix large genesis file commit #374

Merged
merged 5 commits into from
May 4, 2021
Merged

fix large genesis file commit #374

merged 5 commits into from
May 4, 2021

Conversation

KamiD
Copy link
Contributor

@KamiD KamiD commented Mar 5, 2021

Closes: #373

@KamiD KamiD requested a review from robert-zaremba as a code owner March 5, 2021 06:36
robert-zaremba
robert-zaremba reviewed Mar 15, 2021
View reviewed changes
Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution.
Could you add a test for reset sync in an async mode please?

nodedb.go
if err != nil {
panic(err)
}
ndb.batch.Close()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we don't loos data in an async mode here?

@robert-zaremba
Copy link
Collaborator

Hi @KamiD , we are going to tag a new release. Could you respond on the comment above so we can merge this PR?

robert-zaremba
robert-zaremba reviewed May 4, 2021
View reviewed changes
@robert-zaremba
Update nodedb.go
e4e3103 
changing genesis version check
robert-zaremba
robert-zaremba approved these changes May 4, 2021
View reviewed changes
Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@robert-zaremba robert-zaremba added the S:automerge Automatic merge and/or update Pull requests label May 4, 2021
@robert-zaremba robert-zaremba merged commit daefaaf into cosmos:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert-zaremba robert-zaremba robert-zaremba approved these changes

Assignees
No one assigned
Labels
S:automerge Automatic merge and/or update Pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Too large genesis file committed to panic with out of memory
2 participants
@KamiD @robert-zaremba