Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End to End tests for IBC upgrade client #62

Closed
4 tasks
colin-axner opened this issue Oct 28, 2020 · 1 comment
Closed
4 tasks

End to End tests for IBC upgrade client #62

colin-axner opened this issue Oct 28, 2020 · 1 comment
Labels
testing Testing package and unit/integration tests

Comments

@colin-axner
Copy link
Contributor

Summary

During internal audit we noticed that message handling was missing from handler.go. This means it was not possible to successfully execute an upgrade message (since it wasn't being routed). We should add tests to ensure upgrade works from end to end.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@colin-axner colin-axner transferred this issue from cosmos/cosmos-sdk Mar 5, 2021
@colin-axner colin-axner added the testing Testing package and unit/integration tests label Apr 21, 2021
faddat referenced this issue in notional-labs/ibc-go Feb 23, 2022
@ethanfrey
Merge pull request #62 from cosmwasm/add-contributors
678d0d7 
Add list of contributors
@crodriguezvega
Copy link
Contributor

Closing this in favor of #2074.

CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@tzdybal
Extend DA layer client interface (cosmos#83)
9d4a9d3 
- Add CheckBlockAvailability method (resolves cosmos#61)
- Add BlockRetriever interface (resolves cosmos#62)
- Extend mock implementation (resolves cosmos#63)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Testing package and unit/integration tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crodriguezvega @colin-axner